gh-106320: Remove private _PyOS_IsMainThread() function#108605
Merged
vstinner merged 1 commit intopython:mainfrom Aug 29, 2023
Merged
gh-106320: Remove private _PyOS_IsMainThread() function#108605vstinner merged 1 commit intopython:mainfrom
vstinner merged 1 commit intopython:mainfrom
Conversation
Move the following private API to the internal C API (pycore_signal.h): _PyOS_IsMainThread() and _PyOS_SigintEvent().
vstinner
force-pushed
the
pycore_signal
branch
from
063392b to
f3eaba7
Compare
Contributor
|
This breaks tensorstore, specifically due to the usage of It is used in order to make a blocking wait within the main thread interruptible via Control+C on Windows. I don't know of any easy alternative. For now I will be using the workaround of copying the declaration to my own source file, but if the function is eventually removed entirely that won't work. |
Member
Author
|
Would you mind to open a new issue since this one is closed? Please explain your use case and why you need this function to be exposed. |
Member
Author
|
Ping @jbms. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the following private API to the internal C API (pycore_signal.h):
No longer export these functions.